Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(digital_ocean): refactor digital ocean provider and task to conform to new interfaces #161

Merged
merged 50 commits into from
Jan 27, 2025
Merged

chore(digital_ocean): refactor digital ocean provider and task to conform to new interfaces #161

merged 50 commits into from
Jan 27, 2025

Conversation

nadim-az
Copy link
Collaborator

@nadim-az nadim-az commented Jan 13, 2025 •
edited
Loading

sample_run.txt
sample digitalocean_simapp run result

@nadim-az nadim-az marked this pull request as draft January 13, 2025 11:43
@nadim-az nadim-az force-pushed the na/refactor-digitaloceanprovider branch from 184b96c to 12a6c59 Compare January 13, 2025 16:29
@nadim-az nadim-az force-pushed the na/refactor-digitaloceanprovider branch from c48ca91 to c632eb5 Compare January 14, 2025 12:38
@nadim-az nadim-az changed the base branch from zygis/refactor-provider-and-task to zygis/conform-to-new-interfaces January 14, 2025 12:39
nadim-az
nadim-az commented Jan 14, 2025
View reviewed changes
cosmos/chain/chain.go Outdated Show resolved Hide resolved
@Zygimantass Zygimantass force-pushed the zygis/conform-to-new-interfaces branch from 7eefa6a to abfeaa6 Compare January 15, 2025 10:20
Base automatically changed from zygis/conform-to-new-interfaces to release/v3.x.x January 15, 2025 10:25
@nadim-az nadim-az force-pushed the na/refactor-digitaloceanprovider branch from 0da9e6b to f98e67c Compare January 15, 2025 20:45
Zygimantass
Zygimantass reviewed Jan 16, 2025
View reviewed changes
core/types/chain.go Outdated Show resolved Hide resolved
@nadim-az nadim-az force-pushed the na/refactor-digitaloceanprovider branch from 0018e6f to 379af08 Compare January 16, 2025 19:45
@nadim-az nadim-az marked this pull request as ready for review January 17, 2025 17:30
@Zygimantass Zygimantass force-pushed the na/refactor-digitaloceanprovider branch from f1c7568 to 1ad307f Compare January 20, 2025 11:32
Zygimantass
Zygimantass reviewed Jan 20, 2025
View reviewed changes
core/provider/digitalocean/droplet.go Outdated Show resolved Hide resolved
core/provider/digitalocean/droplet.go Outdated Show resolved Hide resolved
core/provider/digitalocean/droplet.go Outdated Show resolved Hide resolved
core/provider/digitalocean/provider.go Outdated Show resolved Hide resolved
core/provider/digitalocean/provider.go Outdated Show resolved Hide resolved
core/provider/digitalocean/task.go Outdated Show resolved Hide resolved
core/provider/digitalocean/task.go Outdated Show resolved Hide resolved
@nadim-az nadim-az force-pushed the na/refactor-digitaloceanprovider branch from 8e6239c to 6a7a2f5 Compare January 20, 2025 18:20
Zygimantass and others added 26 commits January 23, 2025 02:29
@Zygimantass @nadim-az
fix: init provider state before using it in creating the firewall
a119818
@nadim-az
droplet id in task states should be a string
d6c2a1e
@nadim-az
get public ip address through ifconfig instead of user input
f1ab792
@nadim-az
missing logger in restorechain
ac0c8dc
@nadim-az
test: add e2e test
9737a09
@nadim-az
refactor
c0459e0
@nadim-az
create -> restore -> create
bfbb614
@nadim-az
bug fix
55384ee
@nadim-az
test: e2e docker test
ae78d38
@nadim-az
genesis functions should use RunCommandWhileStopped
3c5e94f
@nadim-az
move serializable fields to state
0990f41
@nadim-az
chore: remove provider reference from task struct
9b89f56
@nadim-az
fix bad rebase
f3b70e3
@nadim-az
lint
f2c49c1
@nadim-az
fix tests
763152b
@nadim-az
use network name
93dcdeb
@nadim-az
add back AllocatedIPs to state
1e13c94
@nadim-az
bad rebase
c6668a1
@nadim-az
refactor image pull logic
d70948e
@nadim-az
use getState everywhere
9a5568b
@nadim-az
remove provider name field from task state
6b600c7
@nadim-az
add test for remove task
29f1a58
@nadim-az
move docker client to provider/clients
d3a70f1
@nadim-az
removeTaskFunc moved to top-level provider package
e96f184
@nadim-az
move tests to cosmos package
ec0afde
@nadim-az
upgrade to v3
d930bbc
@nadim-az nadim-az force-pushed the na/refactor-digitaloceanprovider branch from 240346e to d930bbc Compare January 23, 2025 00:39
@Zygimantass Zygimantass merged commit 17d921a into release/v3.x.x Jan 27, 2025
3 checks passed
@Zygimantass Zygimantass deleted the na/refactor-digitaloceanprovider branch January 27, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zygimantass Zygimantass Zygimantass approved these changes

@aljo242 aljo242 Awaiting requested review from aljo242 aljo242 is a code owner

@Eric-Warehime Eric-Warehime Awaiting requested review from Eric-Warehime Eric-Warehime is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadim-az @Zygimantass